feat: APP-322 terassos project filters UI #2487
Open
+649
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wgardiner
force-pushed
the
feat-APP-322-terassos-project-filters-ui
branch
from
15faeb1
to
5383368
Compare
|
@wgardiner you can use the draft PR feature from github here if you think that's still a draft |
wgardiner
force-pushed
the
feat-APP-322-terassos-project-filters-ui
branch
from
b699b7b
to
26002ca
Compare
wgardiner
changed the title
blushi
changed the title
flagrede
reviewed
Oct 8, 2024
There was a problem hiding this comment.
Good work on this PR, the UI looks nice!
Left a few comments, the biggest thing might be that the PR heavily rely on MUI instead of tailwind. We want to get rid of MUI in the long term so new components should not introduce new usage of MUI.
If this is too much of a pain to rewrite it for this PR, it's ok to leave it as it is but for new components it would be best to favor tailwind usage.
web-components/src/components/icons/terassos/ColombiaRegionIcon/ColombiaRegionIcon.tsx
Outdated
Show resolved
Hide resolved
web-components/src/components/icons/terassos/ColombiaRegionIcon/ColombiaRegionIcon.tsx
Outdated
Show resolved
Hide resolved
web-components/src/components/icons/terassos/ColombiaRegionIcon/ColombiaRegionIcon.tsx
Outdated
Show resolved
Hide resolved
web-components/src/components/icons/terassos/ColombiaRegionIcon/ColombiaRegionIcon.tsx
Outdated
Show resolved
Hide resolved
web-components/src/components/icons/terassos/ColombiaRegionIcon/ColombiaRegionIcon.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
5
to
19
| <Box | ||
| display="flex" | ||
| alignItems="center" | ||
| justifyContent="center" | ||
| width="24px" | ||
| height="24px" | ||
| padding="3px" | ||
| borderRadius="50%" | ||
| fontSize="12px" | ||
| fontWeight={700} | ||
| sx={{ | ||
| borderRadius: '40px', | ||
| border: '1px dashed var(--surface-stroke, #D2D5D9)', | ||
| background: 'var(--surface-selected-item-background, #EFEFEF)', | ||
| ml: 2, | ||
| }} | ||
| // eslint-disable-next-line lingui/no-unlocalized-strings | ||
| > | ||
| ha. | ||
| </Box> |
There was a problem hiding this comment.
We should use Tailwind instead of MUI.
There was a problem hiding this comment.
I moved border radius and margin to use tailwind, but in this PR I don't yet have the Tailwind variables that I need to use here, so I can update it after we get the design tokens PR merged.
web-components/src/components/organisms/ProjectFilters/ProjectFilter.TagFilter.tsx
Show resolved
Hide resolved
web-components/src/components/organisms/ProjectFilters/ProjectFilters.tsx
Outdated
Show resolved
Hide resolved
wgardiner
force-pushed
the
feat-APP-322-terassos-project-filters-ui
branch
from
e7d1d2f
to
8d49167
Compare
…or ColombiaRegionIcon, migrate MUI styling to tailwind
wgardiner
force-pushed
the
feat-APP-322-terassos-project-filters-ui
branch
from
8d49167
to
a77969d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: APP-322
This PR adds UI for Terassos project filters and an approach for customizing color SVG colors
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...